-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple collections support in the destination #131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulb
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Once this ships I'll rebase #129.
maha-hajja
reviewed
Apr 12, 2024
7 tasks
lovromazgon
added a commit
that referenced
this pull request
Apr 24, 2024
* feat: read from multiple tables * use sdk constant * feat(longpoll): use opencdc.collection * read from all tables * update paramgen.go * update readme * restore readme * read columns from multiple tables * fix typo * restore * leftovers from #131 * more leftovers * update readme on destination * update * update readme * update comment * update comment * use opencdc constant * start making changes on readme * address after rebase * wip * wip * tie snapshot iterator into longpolling mode * get table key if not supplied manually * ensure snapshot iterator waits for all acks * fix snapshot iterator tests * add test for ensuring iterator waits for acks * fix cdc tests * undo changes on readme * address PR review * use pg_tables --------- Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes ConduitIO/conduit#1474.
In the absence of the metadata in the Pg source connector, I've used a processor to insert the metadata:
Tested with a static table name and also the default Go template.
I've renamed the GitHub job
build
totest
because it more accurately describes what it does.build
is a required PR check, but I'll handle the rename once the PR has been approved.Quick checks: